Skip to content

Significant performance improvements across tagImagesWithPerfTags#720

Open
DogmaDragon wants to merge 3 commits into
stashapp:mainfrom
DogmaDragon:tagImagesWithPerfTags-update
Open

Significant performance improvements across tagImagesWithPerfTags#720
DogmaDragon wants to merge 3 commits into
stashapp:mainfrom
DogmaDragon:tagImagesWithPerfTags-update

Conversation

@DogmaDragon
Copy link
Copy Markdown
Contributor

@DogmaDragon DogmaDragon commented May 30, 2026

Related PR #718

@DogmaDragon DogmaDragon added the type:plugin Plugins label May 30, 2026
@discourse-stashapp
Copy link
Copy Markdown

This pull request has been mentioned on Stash Forum. There might be relevant details there:

https://discourse.stashapp.cc/t/tag-images-from-performer-tags/2059/3

Copy link
Copy Markdown
Contributor

@spaceyuck spaceyuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bulk update has completely different purpose than the per image hook, Bulk update now inherits gallery attributes down to images, but that's a completely different plugin.

Maybe something got committed wrong by accident, but this is halfway to changing plugin scope completely.

hook_id = hook["id"]
hook_type = hook.get("type", "")

if hook_type in ["Gallery.Update.Post", "Gallery.Create.Post"]:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gallery hooks not in manifest, this will never be called.

query["tags"] = {"value": [exclusion_marker_tag_id], "modifier": "EXCLUDES"}

try:
total_count = stash.find_galleries(f=query, filter={"page": 1, "per_page": 1}, get_count=True)[0]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole processAll() no longer inherits tags from performers to images, it is now a gallery to image inheritance logic, which completely changes the purpose of the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants