Skip to content

Conversation

@arad-starkware
Copy link
Collaborator

@arad-starkware arad-starkware commented Dec 4, 2025

This change is Reviewable


Note

Updates README to simplify dependencies and installation, switching to Scarb-based build instructions and optional Starknet Foundry.

  • Docs (README):
    • Dependencies: Replace Turbo/pnpm stack with explicit tooling list: Scarb and optional Starknet foundry.
    • Installation: Simplify to scarb build workflow; add scarb --release build for release builds; mention installing deps (e.g., via asdf).

Written by Cursor Bugbot for commit 7fb9d7a. This will update automatically on new commits. Configure here.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arad-starkware arad-starkware self-assigned this Dec 4, 2025
@arad-starkware arad-starkware marked this pull request as ready for review December 4, 2025 09:20
@arad-starkware arad-starkware force-pushed the arad/doc_update_readme_dependencies_and_installation_sections branch from 3521736 to 7fb9d7a Compare December 4, 2025 09:21
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.77%. Comparing base (c8d4f20) to head (7fb9d7a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          42       42           
  Lines       10102    10102           
=======================================
  Hits         9675     9675           
  Misses        427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

Copy link
Collaborator Author

arad-starkware commented Dec 4, 2025

Merge activity

  • Dec 4, 10:35 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 4, 10:35 AM UTC: @arad-starkware merged this pull request with Graphite.

@arad-starkware arad-starkware merged commit 6294afd into main Dec 4, 2025
8 checks passed
@arad-starkware arad-starkware deleted the arad/doc_update_readme_dependencies_and_installation_sections branch December 4, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants