Skip to content

Conversation

@arad-starkware
Copy link
Collaborator

@arad-starkware arad-starkware commented Nov 25, 2025

This change is Reviewable


Note

Update flow ideas doc: add a Views section and expand/normalize migration and balance test scenarios.

  • Docs (src/flow_test/flow_ideas.md):
    • New section: Add Views with cases for staker/member balance changes and current-epoch balance views.
    • Expanded scenarios:
      • k=1 -> k=2 balances: add delegator/staker claim and delegation edge cases.
      • Migration Member: add V0->V1->V3 flow and refine multiple reward/update-balance permutations.
      • Migration Staker: add additional enter/upgrade/attest sequences (e.g., V0/V1 to V3).
      • Pool member current-epoch migration: add explicit cases for V0/V1 paths.
    • Cleanup: normalize bullet formatting and remove duplicates/minor typos.

Written by Cursor Bugbot for commit a1ef5f2. This will update automatically on new commits. Configure here.

Copy link
Collaborator Author

arad-starkware commented Nov 25, 2025

@arad-starkware arad-starkware self-assigned this Nov 25, 2025
@arad-starkware arad-starkware marked this pull request as ready for review November 25, 2025 11:40
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.60%. Comparing base (620bfeb) to head (a1ef5f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          42       42           
  Lines        9754     9754           
=======================================
  Hits         9325     9325           
  Misses        429      429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@noa-starkware noa-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @arad-starkware)


src/flow_test/flow_ideas.md line 79 at r1 (raw file):

- staker enter in V0, advance epoch, update balance, advance epoch, update balance, upgrade to V3, attest 
- staker enter in V1, advance epoch, update balance, advance epoch, update balance, upgrade to V3, attest 
- staker in V2, update balance staker+update balance pool, upgrade, attest in current epoch, attest in next epoch, attest in next next epoch

lets keep that test, Im not sure we cover the same with the next one.

@arad-starkware arad-starkware force-pushed the arad/chore_update_flow_ideas branch from e8b4e7d to 631614f Compare November 25, 2025 15:32
Copy link
Collaborator Author

@arad-starkware arad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @noa-starkware)


src/flow_test/flow_ideas.md line 79 at r1 (raw file):

Previously, noa-starkware wrote…

lets keep that test, Im not sure we cover the same with the next one.

Done.

Copy link
Collaborator

@noa-starkware noa-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @arad-starkware)

@arad-starkware arad-starkware force-pushed the arad/chore_update_flow_ideas branch from 631614f to a1ef5f2 Compare November 26, 2025 08:01
@arad-starkware arad-starkware merged commit b027a32 into main Nov 26, 2025
7 of 8 checks passed
Copy link
Collaborator Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants