-
Notifications
You must be signed in to change notification settings - Fork 58
apollo_l1_provider: create l1 message provider config struct #8075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: arni/l1_provider/config/scraper_config_to_config_file
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e58ff56
to
73beece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @giladchase)
crates/apollo_l1_provider/src/config.rs
line 33 at r1 (raw file):
]; sub_configs.into_iter().flatten().collect()
I'm not sure what the final structure would be in this case. Would it just have two fields: l1_provider_config and l1_scraper_config? I think maybe there's a way to do this without vec! and the flatten that would make that more obvious.
Also, you probably want to run the binary that produces the config json files.
Previously, guy-starkware wrote…
Regarding how unreadable this flatten is - fixed. Thanks - I hate it. This struct is not used anywhere in this PR. It is first used in the next PR: #8076. |
cf946b8
to
f304a6b
Compare
73beece
to
cd73ed8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
crates/apollo_l1_provider/src/config.rs
line 24 at r2 (raw file):
pub l1_provider_config: L1ProviderConfig, pub l1_scraper_config: L1ScraperConfig, }
As discussed with @guy-starkware .
We should consider making this a flat configuration, which will replace both L1ProviderConfig
and L1ScraperConfig
.
Code quote:
#[derive(Clone, Debug, Default, Serialize, Deserialize, Validate, PartialEq)]
pub struct L1MessageProviderConfig {
pub l1_provider_config: L1ProviderConfig,
pub l1_scraper_config: L1ScraperConfig,
}
cd73ed8
to
c829762
Compare
fe0582b
to
a634665
Compare
c829762
to
8d6e846
Compare
a634665
to
e0b1fbc
Compare
8d6e846
to
c3988a8
Compare
e0b1fbc
to
8bd3e10
Compare
3203369
to
cf7e240
Compare
8bd3e10
to
2a323db
Compare
cf7e240
to
e87fc07
Compare
2a323db
to
c388197
Compare
In this PR, we create the struct
L1MessageProviderConfig
.