-
Notifications
You must be signed in to change notification settings - Fork 57
deployment: enforce hostname max length 64 characters #8068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-v0.14.0
Are you sure you want to change the base?
deployment: enforce hostname max length 64 characters #8068
Conversation
023e1a4
to
cfb993d
Compare
cfb993d
to
cfa4a95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @idan-starkware)
b134e97
to
4109cc0
Compare
646c788
to
4e3f643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @idan-starkware)
crates/apollo_deployments/resources/deployments/potc2/deployment_config_hybrid_0.json
line 50 at r2 (raw file):
"ingress": { "domain": "starknet.io", "dns_name": "apollo-potc-2-mock-sharp-0",
These are auto-generated files, you cannot change them.
Code quote:
"dns_name": "apollo-potc-2-mock-sharp-0",
4e3f643
to
1c42969
Compare
No description provided.