Skip to content

deployment: enforce hostname max length 64 characters #8068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main-v0.14.0
Choose a base branch
from

Conversation

idan-starkware
Copy link
Collaborator

No description provided.

@idan-starkware idan-starkware self-assigned this Jul 17, 2025
@reviewable-StarkWare
Copy link

This change is Reviewable

@idan-starkware idan-starkware force-pushed the idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit branch from 023e1a4 to cfb993d Compare July 17, 2025 12:43
@idan-starkware idan-starkware enabled auto-merge July 17, 2025 12:44
@idan-starkware idan-starkware force-pushed the idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit branch from cfb993d to cfa4a95 Compare July 17, 2025 13:24
Copy link
Collaborator Author

@idan-starkware idan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @idan-starkware)

@idan-starkware idan-starkware changed the title chore(deployment): enforce hostname max length 64 characters apollo_dashboard: enforce hostname max length 64 characters Jul 17, 2025
@idan-starkware idan-starkware changed the title apollo_dashboard: enforce hostname max length 64 characters deployment: enforce hostname max length 64 characters Jul 17, 2025
@idan-starkware idan-starkware force-pushed the idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit branch 2 times, most recently from b134e97 to 4109cc0 Compare July 17, 2025 14:17
@idan-starkware idan-starkware force-pushed the idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit branch 5 times, most recently from 646c788 to 4e3f643 Compare July 20, 2025 11:26
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @idan-starkware)


crates/apollo_deployments/resources/deployments/potc2/deployment_config_hybrid_0.json line 50 at r2 (raw file):

      "ingress": {
        "domain": "starknet.io",
        "dns_name": "apollo-potc-2-mock-sharp-0",

These are auto-generated files, you cannot change them.

Code quote:

        "dns_name": "apollo-potc-2-mock-sharp-0",

@idan-starkware idan-starkware force-pushed the idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit branch from 4e3f643 to 1c42969 Compare July 20, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants