deployment: enforce hostname max length 64 characters #8068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
idan-starkware
force-pushed
the
idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit
branch
from
023e1a4 to
cfb993d
Compare
shay-starkware
approved these changes
Jul 17, 2025
idan-starkware
force-pushed
the
idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit
branch
from
cfb993d to
cfa4a95
Compare
shay-starkware
approved these changes
Jul 17, 2025
idan-starkware
commented
Jul 17, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @idan-starkware)
idan-starkware
changed the title
idan-starkware
changed the title
idan-starkware
force-pushed
the
idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit
branch
2 times, most recently
from
b134e97 to
4109cc0
Compare
shay-starkware
approved these changes
Jul 17, 2025
idan-starkware
force-pushed
the
idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit
branch
5 times, most recently
from
646c788 to
4e3f643
Compare
Itay-Tsabary-Starkware
requested changes
Jul 20, 2025
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @idan-starkware)
crates/apollo_deployments/resources/deployments/potc2/deployment_config_hybrid_0.json line 50 at r2 (raw file):
"ingress": { "domain": "starknet.io", "dns_name": "apollo-potc-2-mock-sharp-0",
These are auto-generated files, you cannot change them.
Code quote:
"dns_name": "apollo-potc-2-mock-sharp-0",
idan-starkware
force-pushed
the
idan/main-v0.14.0/17-07-chore-enforce-hostname-character-limit
branch
from
4e3f643 to
1c42969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.