Skip to content

deployment: add http server port to the deployment file #8056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nadin-Starkware
Copy link
Collaborator

No description provided.

@nadin-Starkware nadin-Starkware marked this pull request as ready for review July 17, 2025 07:21
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Jul 17, 2025

Artifacts upload workflows:

Copy link
Collaborator Author

nadin-Starkware commented Jul 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jul 17, 2025

Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [35.056 ms 35.120 ms 35.188 ms] change: [-4.2743% -2.6143% -1.1347%] (p = 0.00 < 0.05) Performance has improved. Found 4 outliers among 100 measurements (4.00%) 3 (3.00%) high mild 1 (1.00%) high severe

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 26 of 26 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware changed the base branch from 07-14-deployment_add_monitoring_endpoint_port_to_the_deployment_file to graphite-base/8056 July 17, 2025 12:20
@nadin-Starkware nadin-Starkware force-pushed the 07-17-deployment_add_http_server_port_to_the_deployment_file branch from 328e876 to 5d05d35 Compare July 17, 2025 12:20
@nadin-Starkware nadin-Starkware changed the base branch from graphite-base/8056 to main July 17, 2025 12:20
Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2.
Reviewable status: 26 of 27 files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware added this pull request to the merge queue Jul 20, 2025
Merged via the queue into main with commit 62c7f4a Jul 20, 2025
37 of 58 checks passed
chudkowsky pushed a commit to chudkowsky/sequencer that referenced this pull request Jul 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants