Skip to content

apollo_consensus_orchestrator: remove some panics from context #8047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main-v0.14.0
Choose a base branch
from

Conversation

matan-starkware
Copy link
Contributor

eth to fri rate: discussed solution on slack, needed due to historic blocks.
client errors: if a remote component disconnects this shouldn't cause us to panic

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

matan-starkware commented Jul 16, 2025

eth to fri rate: discussed solution on slack, needed due to historic blocks.
client errors: if a remote component disconnects this shouldn't cause us to panic
@matan-starkware matan-starkware force-pushed the matan/clean_context_panics branch from 36e46e8 to 8e5a64b Compare July 16, 2025 13:44
Copy link
Contributor

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)


crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs line 753 at r1 (raw file):

                Ok(response) => break response,
                Err(BatcherClientError::BatcherError(e)) => {
                    panic!("Failed to add decision due to batcher error: {e:?}");

Beyond the scope of this PR but should this cause a panic? maybe add a TODO if it shouldn't
(same for the other methods that wrap client calls)

Copy link
Contributor

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants