Skip to content

Remove unnecessary clone operations #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2025
Merged

Remove unnecessary clone operations #8779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/cairo-lang-filesystem/src/db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ pub fn update_file_overrides_input_helper(
let db_ref: &dyn Database = db;
let mut overrides = files_group_input(db_ref).file_overrides(db_ref).clone().unwrap();
match content {
Some(content) => overrides.insert(file.clone(), content),
Some(content) => overrides.insert(file, content),
None => overrides.swap_remove(&file),
};
overrides
Expand Down
2 changes: 1 addition & 1 deletion crates/cairo-lang-filesystem/src/db_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ fn test_flags() {

let add_withdraw_gas_flag_id = FlagLongId("add_withdraw_gas".into());
db.set_flag(add_withdraw_gas_flag_id.clone(), Some(Arc::new(Flag::AddWithdrawGas(false))));
let id = add_withdraw_gas_flag_id.clone().intern(&db);
let id = add_withdraw_gas_flag_id.intern(&db);

assert_eq!(*db.get_flag(id).unwrap(), Flag::AddWithdrawGas(false));
assert!(db.get_flag(FlagId::new(&db, FlagLongId("non_existing_flag".into()))).is_none());
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ fn run_e2e_test(
.iter()
.map(|(func_id, cost)| format!("{func_id}: {cost:?}"))
.join("\n");
res.insert("function_costs".into(), function_costs_str.to_string());
res.insert("function_costs".into(), function_costs_str);
}

TestRunnerResult::success(res)
Expand Down