-
Notifications
You must be signed in to change notification settings - Fork 805
docs: migration guide v7-v8 #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
www/docs/guides/provider_instance.md
Outdated
@@ -41,8 +41,9 @@ The Starknet.js version must align with the RPC version supported by the chosen | |||
| v0.5.0 | Starknet.js v5.23.0 | | |||
| v0.5.1 | Starknet.js v5.29.0 or v6.1.0 | | |||
| v0.6.0 | Starknet.js v6.24.1 | | |||
| v0.7.1 | Starknet.js v6.24.1 or v7.0.1 | | |||
| v0.8.0 | Starknet.js v7.0.1 | | |||
| v0.7.1 | Starknet.js v6.24.1 or v7.x.x | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v7.6.4 in L44-45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it in as v7.x.x
and truncated the old Starknet versions and the patch element from the new ones so the list a bit more general and concise.
| Lava | v0_6, v0_7, v0_8 | v0_8 | | ||
| Local Pathfinder v0.16.2 | v0_6, v0_7, v0_8 | N/A | | ||
| Local Juno v0.14.2 | v0_6, v0_7, v0_8 | N/A | | ||
| Node | with public url | with API key | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainnet is not yet handling v9.
www/docs/guides/provider_instance.md
Outdated
| Local Juno v0.14.2 | v0_6, v0_7, v0_8 | N/A | | ||
| Node | with public url | with API key | | ||
| -----------------------: | :-------------: | :----------: | | ||
| Alchemy | No | v0_8, v0_9 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked that they have all performed upgrades?
If not, I can run my tests scripts to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Entire part of Docs should be removed as it is, and replaced with link to some test or script that can be run to confirm actual status. As this way of defining it in docs is hard to maintain.
If you like/already have some script for this, please just remove this and add link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I walked back these node provider changes with v0_6 removed. I'll leave it to Phil to update or replace them in a new PR.
|
||
**Local Starknet Devnet network:** | ||
|
||
| Node | with public url | with API key | | ||
| ---------------------: | :-------------: | :----------: | | ||
| starknet-devnet v0.2.4 | v0_7 | N/A | | ||
| starknet-devnet v0.3.0 | v0_8 | N/A | | ||
| starknet-devnet v0.4.x | v0_8 | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.4.3
www/docs/guides/migrate_v7_v8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
More than 500 lines for a migration guide is a bit long, but more is better than less.
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Motivation and Resolution
Checklist: