Conversation
Author
|
Feel free to give feedback in case you’re interested in merging only part of these changes. |
Member
Hi, I won't have time to review this PR until Stalwart Mail Server reaches |
RoDmitry
force-pushed
the
send_msg
branch
2 times, most recently
from
April 12, 2024 10:00
63170ef to
737f51d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_msg(&mut self, message: &Message<'x>)to send message which was already transformed usingIntoMessage. Now you can have ownedMessage, so if any error occurs, you don't loose the entire message, so you can send it again.sign(&mut self, signer: &DkimSigner<_>)method onMessage, which signs message in place, and then message can be sent using usualsend().#[inline], because compiler does not inline by default, as far as I know, so you need to tell it which function you think may be inlined. It improves performance.