Skip to content

Generated with Hive: Fix HALTED state input bar, optimistic retry, and mock data in TaskChatViewController and WorkspaceTasksViewController #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomastiminskas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generated with Hive: Fix HALTED state input bar, optimistic retry, and mock data in TaskChatViewController and WorkspaceTasksViewController #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion sphinx/Scenes/Dashboard/Workspaces/Mocks/HiveFeatureMocks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,18 @@ extension WorkspaceTask {
"updatedAt": "2026-03-03T09:00:00Z"
] as [String: Any])

return [json1, json2, json3, json4].compactMap { WorkspaceTask(json: $0) }
let json5 = JSON([
"id": "task-halted-001",
"title": "Fix authentication token refresh",
"status": "IN_PROGRESS",
"priority": "HIGH",
"workflowStatus": "HALTED",
"chatMessageCount": 2,
"repository": ["name": "sphinx-ios-v2"],
"updatedAt": "2026-03-04T11:00:00Z"
] as [String: Any])

return [json1, json2, json3, json4, json5].compactMap { WorkspaceTask(json: $0) }
}
}

Expand Down
15 changes: 13 additions & 2 deletions sphinx/Scenes/Dashboard/Workspaces/TaskChatViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,9 @@ class TaskChatViewController: UIViewController {

workflowStatusView.onRetryTapped = { [weak self] in
guard let self else { return }
API.sharedInstance.retryTaskWorkflowWithAuth(taskId: self.task.id, callback: {}, errorCallback: {})
API.sharedInstance.retryTaskWorkflowWithAuth(taskId: self.task.id, callback: { [weak self] in
DispatchQueue.main.async { self?.applyWorkflowStatus(.IN_PROGRESS) }
}, errorCallback: {})
}

chatTableView.keyboardDismissMode = .interactive
Expand Down Expand Up @@ -869,7 +871,7 @@ class TaskChatViewController: UIViewController {
private func applyWorkflowStatus(_ status: WorkflowStatus, animated: Bool = true) {
workflowStatusView.status = status
switch status {
case .IN_PROGRESS, .HALTED:
case .IN_PROGRESS:
updateStatusViewHeight()
workflowStatusView.show(animated: animated)
if animated {
Expand All @@ -878,6 +880,15 @@ class TaskChatViewController: UIViewController {
self.view.layoutIfNeeded()
}
setInputEnabled(false)
case .HALTED:
updateStatusViewHeight()
workflowStatusView.show(animated: animated)
if animated {
UIView.animate(withDuration: 0.2) { self.view.layoutIfNeeded() }
} else {
self.view.layoutIfNeeded()
}
setInputEnabled(true)
case .PENDING, .COMPLETED, .ERROR, .FAILED:
workflowStatusView.setStepDetail(nil)
workflowStatusHeightConstraint.constant = 0
Expand Down
8 changes: 7 additions & 1 deletion sphinx/Scenes/Dashboard/Workspaces/WorkspaceTasksViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,13 @@ extension WorkspaceTasksViewController: UITableViewDataSource, UITableViewDelega
cell.onRetryWorkflowTapped = { [weak self] in
guard let self else { return }
let task = self.tasks[indexPath.row]
API.sharedInstance.retryTaskWorkflowWithAuth(taskId: task.id, callback: {}, errorCallback: {})
API.sharedInstance.retryTaskWorkflowWithAuth(taskId: task.id, callback: { [weak self] in
DispatchQueue.main.async {
guard let self else { return }
self.tasks[indexPath.row].workflowStatus = "IN_PROGRESS"
self.tableView.reloadRows(at: [indexPath], with: .none)
}
}, errorCallback: {})
}
return cell
}
Expand Down