Skip to content

Comments

Sub vaults#339

Open
dfkadyr wants to merge 9 commits intomainfrom
sub-vaults
Open

Sub vaults#339
dfkadyr wants to merge 9 commits intomainfrom
sub-vaults

Conversation

@dfkadyr
Copy link
Contributor

@dfkadyr dfkadyr commented Jan 20, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 20, 2026 08:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces functionality to retrieve and manage sub-vaults within a meta vault structure, allowing users to query information about vaults that are allocated within a parent meta vault.

Changes:

  • Added getSubVaults method to retrieve sub-vault information including APY, assets, and exit queue data
  • Extended the allocator GraphQL query to include APY field
  • Added isStateUpdateRequired function to the DefaultVaultAbi contract

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/services/vault/requests/index.ts Exports the new getSubVaults function and its input type
src/services/vault/requests/getSubVaults/index.ts Implements the main logic for fetching and aggregating sub-vault data
src/services/vault/requests/getSubVaults/getSubVaults.md Provides API documentation for the getSubVaults method
src/services/vault/index.ts Adds the public getSubVaults method to the Vault service class
src/graphql/subgraph/vault/subVaultsQuery.graphql Defines the GraphQL query for fetching sub-vaults
src/graphql/subgraph/vault/index.ts Exports the SubVaults query types and fetch function
src/graphql/subgraph/allocator/allocatorsQuery.graphql Adds apy field to the allocators query
src/contracts/vault/abis/DefaultVaultAbi.json Adds isStateUpdateRequired function to the vault ABI
changelog/next-release.md Documents the addition of the getSubVaults method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 20, 2026 11:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mike-diamond
mike-diamond previously approved these changes Jan 21, 2026
}
]


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty lines?

Cast0001
Cast0001 previously approved these changes Jan 21, 2026
Copilot AI review requested due to automatic review settings January 30, 2026 13:41
@dfkadyr dfkadyr dismissed stale reviews from mike-diamond and Cast0001 via 1a8a7c8 January 30, 2026 13:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* [create-metavault] add metavault creation support

* [create-metavault] fixes

* [create-metavault] improve types
Copilot AI review requested due to automatic review settings February 3, 2026 13:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

dfkadyr and others added 2 commits February 17, 2026 17:18
* add ejectingSubVault and pendingMetaSubVault fields to vault

* add new methods to sub-vaults (add, eject, reject)
Copilot AI review requested due to automatic review settings February 20, 2026 13:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants