Conversation
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds support for specifying a target validator when consolidating validators. The consolidation logic now accepts an optional target_public_key parameter, allowing users to designate a specific validator as the consolidation target rather than automatically selecting one.
Changes:
- Added
target_public_keyparameter to the consolidation flow with validation logic - Bumped version from v4.1.4 to v4.1.5 across documentation and configuration files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/commands/consolidate.py | Added target_public_key parameter and validation logic for target validator selection |
| scripts/install.sh | Updated default version to v4.1.5 |
| pyproject.toml | Updated package version to v4.1.5 |
| README.md | Updated docker image version references to v4.1.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com> # Conflicts: # README.md # pyproject.toml # scripts/install.sh
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Validate the source validator has been active long enough | ||
| if source_validator.activation_epoch > self.max_activation_epoch: | ||
| raise ConsolidationError( | ||
| f'Validator {source_validator.public_key}' |
There was a problem hiding this comment.
Missing space after the public_key value in the error message. The line should have a space before "is not active enough" to maintain consistent formatting with other multi-line error messages in this file.
| else: | ||
| if not target_validator.is_compounding: | ||
| raise ConsolidationError( | ||
| f'The target validator {self.target_public_key}' |
There was a problem hiding this comment.
Missing space after the target_public_key value in the error message. The line should have a space before "is not a compounding validator" to maintain consistent formatting with other multi-line error messages in this file.
2 participants
No description provided.