Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the meta vault architecture by extracting sub-vault management logic into a separate SubVaultsRegistry contract, improving separation of concerns and maintainability.
Changes:
- Extracts sub-vault management logic from meta vaults into a new SubVaultsRegistry contract
- Removes GnoPrivMetaVault in favor of using GnoMetaVault directly
- Adds EthErc20MetaVault and EthPrivErc20MetaVault variants with ERC20 token functionality
Reviewed changes
Copilot reviewed 85 out of 85 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| contracts/vaults/SubVaultsRegistryFactory.sol | New factory contract for deploying SubVaultsRegistry instances |
| contracts/vaults/modules/VaultSubVaults.sol | Refactored to delegate sub-vault operations to SubVaultsRegistry |
| contracts/vaults/gnosis/GnoMetaVault.sol | Updated to use SubVaultsRegistry for sub-vault management |
| contracts/vaults/gnosis/GnoPrivMetaVault.sol | Removed file - functionality merged into GnoMetaVault |
| contracts/vaults/ethereum/EthErc20MetaVault.sol | New ERC20 meta vault implementation |
| contracts/vaults/ethereum/EthPrivErc20MetaVault.sol | New private ERC20 meta vault with whitelist |
| contracts/interfaces/ISubVaultsRegistry.sol | New interface for SubVaultsRegistry contract |
| test/gnosis/GnoPrivMetaVault.t.sol | Removed test file for deleted GnoPrivMetaVault |
| test/EthPrivErc20MetaVault.t.sol | New test file for EthPrivErc20MetaVault |
| test/EthErc20MetaVault.t.sol | New test file for EthErc20MetaVault |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Forge code coverage:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 79 out of 79 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 82 out of 82 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 83 out of 83 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
test/gnosis/GnoPrivMetaVault.t.sol:1
- The GnoPrivMetaVault test file has been completely removed. If GnoPrivMetaVault functionality still exists in the codebase (or has been merged into GnoMetaVault with whitelist capability), ensure adequate test coverage exists elsewhere for the private/whitelisted meta vault functionality on Gnosis.
contracts/vaults/ethereum/EthErc20Vault.sol:1 - Missing closing brace. The
enterExitQueuefunction appears to have an extra opening brace at line 139 that doesn't have a corresponding closing brace, or the code block structure is inconsistent.
// SPDX-License-Identifier: BUSL-1.1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.