Add UptimeRobot all monitors features (updated)#655
Add UptimeRobot all monitors features (updated)#655dguihal wants to merge 5 commits intostakater:masterfrom
Conversation
|
Hey @dguihal Thanks for good work. To continue with this, can you assist us in:
|
|
I'll work on this CRDs already updated |
|
Hey @dguihal thanks for co-operation. We ran our pipeline on top of it and seems like linting has failed. Please can you look after it once more? |
|
@mahmadmujtaba Seems those failures aren't related to my PR I mean I can fix them, but I presume It would be better to have this done on a dedicated PR Outside this, I'm quite stuck on unit testing of the changes because I don't find any appropriate target for POST requests, do you have any hint ?
|
|
hey @dguihal, We can use this PR to fix linting issues and for your second question, try https://restful-api.dev/ service. This allows us to make empty POST requests to test.
and response:
` |


Updated PR from #632
Fixes #603