Implement PIN_STATE command: Only set pins to output when requested - #12
Open
neuschaefer wants to merge 1 commit into
Open
Implement PIN_STATE command: Only set pins to output when requested#12neuschaefer wants to merge 1 commit into
neuschaefer wants to merge 1 commit into
Conversation
This has the advantage that the pico-serprog can stay attached to the board even while a CPU etc. runs on the board and uses the flash.
dan-corneanu
approved these changes
Jan 29, 2024
dan-corneanu
left a comment
There was a problem hiding this comment.
@neuschaefer this change looks good to me.
|
What's still needed to have this PR merged? |
|
I am looking for a SPI flash programmer that can enable/disable output and allow the device to boot. I believe rp2040+this patch does what I am looking for. What is the plan for this PR. Does it look good to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the advantage that the pico-serprog can stay attached to the board even while a CPU etc. runs on the board and uses the flash.
NOTE (cc @dan-corneanu): This doesn't not implement the RESET as in #4 , but RESET pin support could be implemented on top of it.