Skip to content

Conversation

@francesco-stacks
Copy link

@francesco-stacks francesco-stacks commented Nov 21, 2025

Description

Builds on top of #6699, will be rebased once the other PR will be merged.

some consensus tests may not need to be tested for certain clarity versions. This is expecially true for contract calls (that I am testing for the runtime check errors), where we have tens of blocks, where maybe only 1 or 2 clarity versions can be used to deploy the contract.

I decided to specify the excluded versions instead of the "accepted" ones, because this way the tests will be automatically running also for new clarity versions when they will be added.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@francesco-stacks francesco-stacks self-assigned this Nov 21, 2025
@francesco-stacks francesco-stacks changed the title faet: add exclude_clarity_versions to contract consensus tests feat: add exclude_clarity_versions to contract consensus tests Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.45%. Comparing base (cda6a5e) to head (7549019).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/chainstate/tests/consensus.rs 91.66% 1 Missing ⚠️
...slib/src/chainstate/tests/static_analysis_tests.rs 50.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (71.45%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (cda6a5e) and HEAD (7549019). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (cda6a5e) HEAD (7549019)
142 130
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6707      +/-   ##
===========================================
- Coverage    80.03%   71.45%   -8.58%     
===========================================
  Files          577      577              
  Lines       357651   357664      +13     
===========================================
- Hits        286235   255566   -30669     
- Misses       71416   102098   +30682     
Files with missing lines Coverage Δ
stackslib/src/chainstate/tests/consensus.rs 86.99% <91.66%> (-7.85%) ⬇️
...slib/src/chainstate/tests/static_analysis_tests.rs 69.96% <50.00%> (-25.23%) ⬇️

... and 320 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda6a5e...7549019. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@francesco-stacks francesco-stacks marked this pull request as ready for review November 21, 2025 18:24
@francesco-stacks francesco-stacks requested review from a team as code owners November 21, 2025 18:24
@francesco-stacks francesco-stacks added aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task labels Nov 21, 2025
@francesco-stacks francesco-stacks moved this to Status: In Review in Stacks Core Eng Nov 21, 2025
@jacinta-stacks
Copy link
Contributor

LOL I literally have this exact change sitting on a local branch. Thanks for doing.

@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Nov 24, 2025
@francesco-stacks francesco-stacks added this pull request to the merge queue Nov 24, 2025
Merged via the queue into stacks-network:develop with commit ad4a4e2 Nov 24, 2025
303 of 312 checks passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants