-
Notifications
You must be signed in to change notification settings - Fork 715
feat: add exclude_clarity_versions to contract consensus tests
#6707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exclude_clarity_versions to contract consensus tests
#6707
Conversation
exclude_clarity_versions to contract consensus testsexclude_clarity_versions to contract consensus tests
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (71.45%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6707 +/- ##
===========================================
- Coverage 80.03% 71.45% -8.58%
===========================================
Files 577 577
Lines 357651 357664 +13
===========================================
- Hits 286235 255566 -30669
- Misses 71416 102098 +30682
... and 320 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
LOL I literally have this exact change sitting on a local branch. Thanks for doing. |
ad4a4e2
Description
Builds on top of #6699, will be rebased once the other PR will be merged.
some consensus tests may not need to be tested for certain clarity versions. This is expecially true for contract calls (that I am testing for the runtime check errors), where we have tens of blocks, where maybe only 1 or 2 clarity versions can be used to deploy the contract.
I decided to specify the excluded versions instead of the "accepted" ones, because this way the tests will be automatically running also for new clarity versions when they will be added.
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo