-
Notifications
You must be signed in to change notification settings - Fork 715
Add runtime error tests #6698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add runtime error tests #6698
Conversation
Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/add-testing-to-runtime-errors
…g. Also removed MetadataAlreadySet Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… comment Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/add-testing-to-runtime-errors
Signed-off-by: Jacinta Ferrant <[email protected]>
…uint Signed-off-by: Jacinta Ferrant <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6698 +/- ##
===========================================
+ Coverage 79.70% 79.83% +0.13%
===========================================
Files 577 578 +1
Lines 357591 358341 +750
===========================================
+ Hits 285022 286096 +1074
+ Misses 72569 72245 -324
... and 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/add-testing-to-runtime-errors
… into chore/add-testing-to-runtime-errors
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
federico-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small remark. I would have approved and let you decide how to handle it, but I also noticed that your commits are no longer signed. Not sure whether that’s due to your local configuration or the change Jesse made to the CI. Just flagging it so you’re aware.
|
|
||
| #[cfg(any(test, feature = "testing"))] | ||
| pub fn since(epoch: StacksEpochId) -> &'static [StacksEpochId] { | ||
| let idx = Self::ALL | ||
| .iter() | ||
| .position(|&e| e == epoch) | ||
| .expect("epoch not found in ALL"); | ||
|
|
||
| &Self::ALL[idx..] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that we started a new impl StacksEpochId block. Could make sense to merge it with the one below? Or is there a specific reason we kept them separated?
stacks-core/stacks-common/src/types/mod.rs
Lines 479 to 483 in 77f1583
| impl StacksEpochId { | |
| #[cfg(any(test, feature = "testing"))] | |
| pub const fn latest() -> StacksEpochId { | |
| StacksEpochId::Epoch33 | |
| } |
I am not yet convinced that my reasoning about my untested variants is correct. Still looking into it. Especially the AST errors. Having a hard time reasoning out when those would trigger.
Replaces #6690
Closes #6695