Skip to content

Conversation

@francesco-stacks
Copy link

@francesco-stacks francesco-stacks commented Nov 14, 2025

Description

First of 7 PRs that will supersede #6661

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@francesco-stacks francesco-stacks self-assigned this Nov 14, 2025
@francesco-stacks francesco-stacks requested review from a team as code owners November 14, 2025 14:33
@francesco-stacks francesco-stacks added aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task labels Nov 14, 2025
@francesco-stacks francesco-stacks moved this to Status: In Review in Stacks Core Eng Nov 14, 2025
@francesco-stacks francesco-stacks changed the title Chore: first set of consensus tests for CheckErrorKind during contract analysis test: first set of consensus tests for CheckErrorKind during contract analysis Nov 14, 2025
@francesco-stacks francesco-stacks added this pull request to the merge queue Nov 17, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Nov 17, 2025
Merged via the queue into stacks-network:develop with commit 9c94664 Nov 17, 2025
308 of 312 checks passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 77.64706% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.66%. Comparing base (1186a4c) to head (66772cf).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...slib/src/chainstate/tests/static_analysis_tests.rs 77.64% 19 Missing ⚠️

❌ Your project status has failed because the head coverage (71.66%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6686       +/-   ##
============================================
+ Coverage    57.11%   71.66%   +14.55%     
============================================
  Files          576      577        +1     
  Lines       356840   356925       +85     
============================================
+ Hits        203803   255799    +51996     
+ Misses      153037   101126    -51911     
Files with missing lines Coverage Δ
stackslib/src/chainstate/tests/mod.rs 75.48% <ø> (+9.84%) ⬆️
...slib/src/chainstate/tests/static_analysis_tests.rs 77.64% <77.64%> (ø)

... and 424 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1186a4c...66772cf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task locked

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants