-
Notifications
You must be signed in to change notification settings - Fork 13
chore(deps): replace yaml lib #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Tomasz Janiszewski <[email protected]>
Signed-off-by: Tomasz Janiszewski <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README says to do the following instead:
// Old way
import "sigs.k8s.io/yaml/goyaml.v3"
// Recommended way
import "go.yaml.in/yaml/v3"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine, though I'd still recommend to do what the README says:
// Old way
import "sigs.k8s.io/yaml/goyaml.v3"
// Recommended way
import "go.yaml.in/yaml/v3"
Signed-off-by: Tomasz Janiszewski <[email protected]>
Signed-off-by: Tomasz Janiszewski <[email protected]>
@janisz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
gopkg.in/yaml
is not maintained let's follow k8s recommendation and usego.yaml.in/yaml/v3
alternatively we could use https://github.com/goccy/go-yaml but we already have indirect dependency to k8s version and it's a fork ofgithub.com/ghodss/yaml
so we can replace 2 deps with 1 without any code changes.See: