Skip to content

chore(deps): replace yaml lib #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore(deps): replace yaml lib #1960

wants to merge 4 commits into from

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 25, 2025

gopkg.in/yaml is not maintained let's follow k8s recommendation and use go.yaml.in/yaml/v3 alternatively we could use https://github.com/goccy/go-yaml but we already have indirect dependency to k8s version and it's a fork of github.com/ghodss/yaml so we can replace 2 deps with 1 without any code changes.

See:

Signed-off-by: Tomasz Janiszewski <[email protected]>
Signed-off-by: Tomasz Janiszewski <[email protected]>
@janisz
Copy link
Contributor Author

janisz commented Jun 25, 2025

/retest

Copy link
Collaborator

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README says to do the following instead:

// Old way
import "sigs.k8s.io/yaml/goyaml.v3"

// Recommended way
import "go.yaml.in/yaml/v3"

@janisz janisz requested a review from RTann June 26, 2025 09:44
Copy link
Collaborator

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, though I'd still recommend to do what the README says:

// Old way
import "sigs.k8s.io/yaml/goyaml.v3"

// Recommended way
import "go.yaml.in/yaml/v3"

Signed-off-by: Tomasz Janiszewski <[email protected]>
Signed-off-by: Tomasz Janiszewski <[email protected]>
Copy link

openshift-ci bot commented Jun 30, 2025

@janisz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests da43ae6 link false /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants