-
Notifications
You must be signed in to change notification settings - Fork 25
Use P and Z GHA runners #2215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use P and Z GHA runners #2215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2215 +/- ##
=======================================
Coverage 28.83% 28.83%
=======================================
Files 96 96
Lines 5799 5799
Branches 2551 2551
=======================================
Hits 1672 1672
Misses 3408 3408
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9dc35e5
to
22d946a
Compare
585a27a
to
50844a7
Compare
/retest |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, the build speeds are looking far, far healthier now and everything looks a lot simpler. LGTM!
* ROX-29116: (fix) Use ARM GH action workflow runners for ARM builds (#2106) * Revert "Revert GH arm changes (#2107)" * Add arm64 stable, beta, and dev channels for Google COS integration tests (#2096) * Use P and Z GHA runners (#2215) * Use go cross-compilation to speed up test builds on CI (#2210) After adding Arm runners on GHA, we made it so the Arm test image is always built. Unfortunately, because we use QEMU to build the images, the build has gotten quite slow. In order to speed up the build, this change makes it so we cross-compile the binaries for all our supported platforms locally and the image build simply copies the binaries into the final image. --------- Co-authored-by: Robby Cochran <[email protected]>
* Use P and Z GHA runners (#2215) * Use go cross-compilation to speed up test builds on CI (#2210) After adding Arm runners on GHA, we made it so the Arm test image is always built. Unfortunately, because we use QEMU to build the images, the build has gotten quite slow. In order to speed up the build, this change makes it so we cross-compile the binaries for all our supported platforms locally and the image build simply copies the binaries into the final image.
Description
Use Power and Z GHA runners provided by https://github.com/IBM/actionspz
This allows us to greatly simplify our CI workflows, since we no longer need to build images on remove VMs or have dedicated logic for running multi-arch builds conditionally. The new runners build the collector and builder images in a time frame comparable to the x86 and arm ones, so we can just run them on PRs with no major penalty.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI is enough.