Skip to content

Use P and Z GHA runners #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 14, 2025
Merged

Use P and Z GHA runners #2215

merged 7 commits into from
Jul 14, 2025

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Jul 2, 2025

Description

Use Power and Z GHA runners provided by https://github.com/IBM/actionspz

This allows us to greatly simplify our CI workflows, since we no longer need to build images on remove VMs or have dedicated logic for running multi-arch builds conditionally. The new runners build the collector and builder images in a time frame comparable to the x86 and arm ones, so we can just run them on PRs with no major penalty.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI is enough.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.83%. Comparing base (df82808) to head (da689f1).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2215   +/-   ##
=======================================
  Coverage   28.83%   28.83%           
=======================================
  Files          96       96           
  Lines        5799     5799           
  Branches     2551     2551           
=======================================
  Hits         1672     1672           
  Misses       3408     3408           
  Partials      719      719           
Flag Coverage Δ
collector-unit-tests 28.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Molter73 Molter73 force-pushed the mauro/pnz-runners branch from 9dc35e5 to 22d946a Compare July 4, 2025 14:38
@Molter73 Molter73 force-pushed the mauro/pnz-runners branch from 585a27a to 50844a7 Compare July 4, 2025 15:06
@Molter73 Molter73 mentioned this pull request Jul 7, 2025
2 tasks
@Molter73
Copy link
Collaborator Author

Molter73 commented Jul 8, 2025

/retest

@Molter73 Molter73 marked this pull request as ready for review July 8, 2025 12:13
@Molter73 Molter73 requested a review from a team as a code owner July 8, 2025 12:13
@Molter73
Copy link
Collaborator Author

Molter73 commented Jul 8, 2025

/retest

1 similar comment
@Molter73
Copy link
Collaborator Author

Molter73 commented Jul 8, 2025

/retest

Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, the build speeds are looking far, far healthier now and everything looks a lot simpler. LGTM!

@Molter73 Molter73 enabled auto-merge (squash) July 14, 2025 10:19
@Molter73 Molter73 disabled auto-merge July 14, 2025 10:59
@Molter73 Molter73 merged commit 52506e4 into master Jul 14, 2025
87 of 88 checks passed
@Molter73 Molter73 deleted the mauro/pnz-runners branch July 14, 2025 10:59
Molter73 added a commit that referenced this pull request Jul 15, 2025
@Molter73 Molter73 mentioned this pull request Jul 15, 2025
5 tasks
Molter73 added a commit that referenced this pull request Jul 15, 2025
Molter73 added a commit that referenced this pull request Jul 18, 2025
* ROX-29116: (fix) Use ARM GH action workflow runners for ARM builds (#2106)

* Revert "Revert GH arm changes (#2107)"
* Add arm64  stable, beta, and dev channels for Google COS integration tests (#2096)

* Use P and Z GHA runners (#2215)

* Use go cross-compilation to speed up test builds on CI (#2210)

After adding Arm runners on GHA, we made it so the Arm test image is
always built. Unfortunately, because we use QEMU to build the images,
the build has gotten quite slow.

In order to speed up the build, this change makes it so we cross-compile
the binaries for all our supported platforms locally and the image build
simply copies the binaries into the final image.

---------

Co-authored-by: Robby Cochran <[email protected]>
Molter73 added a commit that referenced this pull request Jul 18, 2025
* Use P and Z GHA runners (#2215)

* Use go cross-compilation to speed up test builds on CI (#2210)

After adding Arm runners on GHA, we made it so the Arm test image is
always built. Unfortunately, because we use QEMU to build the images,
the build has gotten quite slow.

In order to speed up the build, this change makes it so we cross-compile
the binaries for all our supported platforms locally and the image build
simply copies the binaries into the final image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants