Skip to content

Delete NWC plaintext credentials that allow payments #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huumn merged 5 commits into from
Sep 15, 2025
Merged

Delete NWC plaintext credentials that allow payments #2367

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
134dbe3
Delete NWC plaintext credentials that allow payments
ekzyis Jul 30, 2025
efc07da
Fix row in Wallet and WalletProtocol not deleted
ekzyis Sep 10, 2025
a84626a
Fix wallet delete because CTE evaluated too late iiuc
ekzyis Sep 10, 2025
baab076
Mention badges
ekzyis Sep 10, 2025
c38df04
Fix missing semicolon
ekzyis Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions prisma/migrations/20250910153121_delete_nwc_recv_with_payments/migration.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
-- delete protocols that have accidentally been saved in plaintext with permissions to spend
DELETE FROM "WalletProtocol"
WHERE id IN (
SELECT "protocolId" FROM "WalletRecvNWC"
WHERE id IN (
7,
67,
140,
157,
158,
166
)
);

-- delete wallets that now have no protocols
DELETE FROM "Wallet"
WHERE NOT EXISTS (SELECT 1 FROM "WalletProtocol" WHERE "walletId" = "Wallet"."id");

-- badges will not be updated but that's okay, not important enough for the effort