Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to update
gix
to version 0.73.The changes were needed because of:
SignatureRef.time
method now returns a&str
. There is aSignatureRef.time()
to getTime
back. This can however fail and return an Error. I replaced all instances wheretime
was accessed directly withtime()?
. In one case, I couldn't use the?
operator because the method did not return aResult
. How do you want this to be handled? Is there some default value that can be used here? The compile error looks like this:SignatureRef.to_owned()
can now fail and needs to handled accordingly (by using the?
operator).RepositoryExtended.commit_ex()
wants aSignatureRef
butSignature
was passed. I assume that because of the updated somewhereSignature
is returned instead ofSignatureRef
. I added a couple ofSignature.to_ref
calls where needed.