feat(stackable-versioned): Add argument to hint for wrapped types#1089
Merged
Conversation
Techassi
force-pushed
the
feat/stackable-versioned-hint-wrapped
branch
from
September 8, 2025 10:04
9538541 to
156b5d2
Compare
Techassi
marked this pull request as ready for review
September 8, 2025 10:05
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
NickLarsenNZ
previously approved these changes
Sep 8, 2025
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
I skim-read this one. Looks fine to me.
One suggestion (will approve anyway since it is a non-functional thing).
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#642 and stackabletech/secret-operator#634.
This PR adds a new argument
#[versioned(hint)]to provide hints for two supported wrapped types:#[versioned(hint(option))]: This hints that the field is wrapped inOption<_>. In the conversionFromimpl blocks this will result in a.map(Into::into)call.#[versioned(hint(vec))]: This hints that the field is wrapped inVec<_>. In the conversionFromimpl blocks this will result in a.into_iter().map(Into::into).collect()call.