Skip to content

fix(spark): propagate exit code of the entrypoint - #1595

Merged
sweb merged 3 commits into
mainfrom
fix/spark-exit-code-propagation
Jul 31, 2026
Merged

fix(spark): propagate exit code of the entrypoint#1595
sweb merged 3 commits into
mainfrom
fix/spark-exit-code-propagation

Conversation

@sweb

@sweb sweb commented Jul 28, 2026

Copy link
Copy Markdown
Member

Description

result=$? sat after the wait loop, so it captured the loop's status (always 0) instead of the entrypoint's.

Tests are covered here: stackabletech/spark-k8s-operator#735

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

Comment thread spark-k8s/stackable/run-spark.sh Outdated
@sweb
sweb marked this pull request as ready for review July 29, 2026 15:02

@razvan razvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sweb
sweb added this pull request to the merge queue Jul 31, 2026
Merged via the queue into main with commit 98b5497 Jul 31, 2026
3 checks passed
@sweb
sweb deleted the fix/spark-exit-code-propagation branch July 31, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants