refactor: Introduce build aggregator#814
Open
adwk67 wants to merge 7 commits into
Open
Conversation
12 tasks
maltesander
reviewed
Jul 10, 2026
| // https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/fernet.html#security-fernet | ||
| // does not document how long the fernet key should be, but recommends using | ||
| // python -c "from cryptography.fernet import Fernet; print(Fernet.generate_key().decode())" | ||
| // which returns `jUm21LuA76YZmrIa9u4eXRg0h0P24MDC9IDOmDvJbfw=`, which has 44 characters, which makes 32 bytes. |
Member
There was a problem hiding this comment.
I dont get how the 44 characters make 32 bytes?
Member
Author
There was a problem hiding this comment.
It's because it's Base64 encoded (plus padding etc.):
$ echo -n 'jUm21LuA76YZmrIa9u4eXRg0h0P24MDC9IDOmDvJbfw=' | base64 -d | wc -c
32
Member
There was a problem hiding this comment.
Ah...i would just remove that comment, the parameter clearly states that it is bytes. Or mention the base64?
Comment on lines
+242
to
+244
| /// Ensures the three shared random Secrets (internal / JWT / Fernet) exist, creating any that are | ||
| /// missing. These are read-or-create client operations, so they cannot be part of the client-free | ||
| /// `build()` step. |
Member
There was a problem hiding this comment.
This is not quite true as discussed, we can switch to deref (-> validate) and build steps.
Member
Author
There was a problem hiding this comment.
As discussed, we'll leave this for a later PR when we can look at it with operators that have similar things (i.e. trino)
maltesander
reviewed
Jul 14, 2026
Co-authored-by: maltesander <malte.sander.it@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#864.
TODO
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker