Skip to content

Provide correct BZip2 information for in-project build #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Provide correct BZip2 information for in-project build #227

wants to merge 2 commits into from

Conversation

DonRumata710
Copy link

Closes #226

@DonRumata710 DonRumata710 changed the title #226 provide correct BZip2 information for in-project build Provide correct BZip2 information for in-project build Jun 18, 2025
@cen1
Copy link
Collaborator

cen1 commented Aug 10, 2025 •
edited
Loading

This line seems a bit suspect:

$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}/${QUAZIP_INCLUDE_PATH}>

QUAZIP_INCLUDE_PATH is defined in the submodule but you are using it in root, I don't think this works.

@cen1 cen1 self-requested a review August 10, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cen1 cen1 Awaiting requested review from cen1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BZIP2 cannot be found in CMake installation if it was build inside quazip
2 participants
@DonRumata710 @cen1