Skip to content

[BUG] Fixed SCL detector #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sevhena merged 3 commits into from
Mar 24, 2025
Merged

[BUG] Fixed SCL detector #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44bbd34
refined string type determination logic in SCL detector
Sevhena Mar 20, 2025
4f93b14
logging changes and fixes
Sevhena Mar 20, 2025
c521182
Made additional fixes + added tests
Sevhena Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/ecooptimizer/analyzers/ast_analyzers/detect_long_element_chain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@ def check_chain(node: ast.Subscript, chain_length: int = 0):
chain_length += 1
current = current.value

print(chain_length)
if chain_length >= threshold:
# Create a descriptive message for the detected long chain
message = f"Dictionary chain too long ({chain_length}/{threshold})"
print(node.lineno)
# Instantiate a Smell object with details about the detected issue
smell = LECSmell(
path=str(file_path),
Expand Down
Loading