feat: add srcery theme for clap#48
Conversation
|
|
|
Looking good! always nice with new inclusions |
|
Still needs to fix the white corners. liuchengxu/vim-clap#380 |
|
Seems that the theme is a bit broken when switching between transparent and regular version. Now that I know that, I might be able to track down the issue. One major issue is as you can see in the original image that the two symbols on either side of the search is colored wrongly. The |
|
hmm, yea transparent background can cause issues, had similar problems in Emacs. Do you have a fix in mind? I had to fork the plugin that caused the issue to be able to offer a fix, but that is less than ideal i think. |
|
Frankly, no clue.. Just a coincidence that I figured out the transparent thing. 😅 Now that I know, it’ll be a lot easier to debug.
What were your fix for the plugin?
… On 8 Aug 2020, at 13:56, Daniel Berg ***@***.***> wrote:
hmm, yea transparent background can cause issues, had similar problems in Emacs. Do you have a fix in mind? I had to fork the plugin that caused the issue to be able to offer a fix, but that is less than ideal i think.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
the problem with the plugin i referred to was that it tried to hide certain leading characters in org-mode files by setting the foreground color to whatever is the default background color was for a given color scheme, but in srcery the color was My fix was to change what the plugin used as a For reference here's my fork, but there is also a pull request thats been open since 2017 from what I can tell, author just isn't maintaining the plugin. Not sure if this is applicable to your issue here, but was similar enough for me to mention it. A possible fix is this case could be to change the hi group for whatever clap uses as a background for that rounded corner, which is probably a link to the |
highlight SignColumn ctermbg=NONE guibg=NONEfixed the problem with the black column. Still needs to fix the white corners on the top bar when transparent is enabled.
Do you think it's bad setting hightlight settings inside a plugin's color schema? Does not seem to be affecting Vim itself. |
|
which settings do you mean? |
|
Setting the |
|
If it works locally for that plugin I'm all for it |
roosta
left a comment
roosta
left a comment
There was a problem hiding this comment.
Excellent solution, had a few thoughts.
MindTooth
force-pushed
the
add_clap_theme
branch
2 times, most recently
from
fc4a33b to
da25a79
Compare
|
Done the finishing touches. Please read the comments to either fix grammer and/or spelling mistakes. Just felt for writing stuff. 😜 Hopefully this is now complete enough for merging. Thanks for the comments and help. |
roosta
left a comment
roosta
left a comment
There was a problem hiding this comment.
This might be overly pedantic, but you did ask 😄 If you don't agree with my suggestions feel free to ignore them.
|
I've tackled the grammar/spelling suggestions. Next is reading the colors from the definitions instead. |
|
Ok, I'll stop now :) hope you found it useful and not to nitpicky. |
|
All feedback is good feedback, right. 😉 |
|
I guess so :) go ahead and merge whenever you're ready |
MindTooth
force-pushed
the
add_clap_theme
branch
from
eb31e3b to
940ce29
Compare
|
Finally we made it happen. 👍🏻 Thanks for all the comments. Much appreciated. |
|
yay! glad I could help 👍 |
feat: add srcery theme for clap
2 participants
No description provided.