Fix longName defaulting to parameter name when not provided #1261 #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojects#1261 Signed-off-by: David Pilar <[email protected]>
Contributor
|
I was working on this as well and had almost the same change set! LGTM 👍 Rebased and merged as 6b1e701. Thank you for your contribution! |
Contributor
Author
|
Yes, that is unfortunate - both of us working on the same problem. I wasn’t sure whether you had already started on this, but since the 4.0.1 release is planned for today, I took a look at it. Moreover, I fixed the option proposal in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1261