Set default sendFailureChannelName to "errorChannel" #10164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Riley <[email protected]>
artembilan
requested changes
Jun 24, 2025
| @@ -77,6 +78,7 @@ public class RabbitStreamMessageHandler extends AbstractMessageHandler { | |||
| public RabbitStreamMessageHandler(RabbitStreamOperations streamOperations) { | |||
| Assert.notNull(streamOperations, "'streamOperations' cannot be null"); | |||
| this.streamOperations = streamOperations; | |||
| this.sendFailureChannelName = IntegrationContextUtils.ERROR_CHANNEL_BEAN_NAME; | |||
There was a problem hiding this comment.
And why don't you reset it back to null, when the mode is sync?
That's not what we have discussed with you.
The default null has still be there for sync mode when we re-throw exception from the Future.get().
Any chances to have something covered with tests in the RabbitStreamMessageHandlerTests, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10163.
the
RabbitStreamMessageHandlerpreviously did not set asendFailureChannelName. Ifsyncwas set to false (as it is in the default constructor forRabbitStreamMessageHandler), then errors thrown by the Rabbit Stream client would be silently discarded.This PR changes the default
sendFailureChannelNameto be"errorChannel".