SSL host config customizations may be lost during Tomcat initialization - #51466
Open
scottfrederick wants to merge 1 commit into
Open
SSL host config customizations may be lost during Tomcat initialization#51466scottfrederick wants to merge 1 commit into
scottfrederick wants to merge 1 commit into
Conversation
Applying an SSL bundle to a Tomcat server replaced any `SSLHostConfig` already registered on the connector for a host name, so an `SSLHostConfig` could not be configured before Spring Boot applied a bundle to it. Reuse any existing `SSLHostConfig` during initial configuration, so an `SSLHostConfig` registered on the connector before the bundle is applied retains settings such as `trustManagerClassName`, `truststoreProvider`, or `truststoreAlgorithm`. Client authentication settings are only applied when creating a new `SSLHostConfig`, so the `certificateVerification` of an existing `SSLHostConfig` is retained rather than being overwritten with the value derived from the `server.ssl.client-auth` property. Signed-off-by: Scott Frederick <scottyfred@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #51290, which retained
SSLHostConfigcustomizations when reloading an SSL bundle. These changes align the initialization and reload code paths by moving all find-or-reuse logic intoaddSslHostConfigso that neither path discards configuration that already exists in the connector.