Skip running checks during IntelliJ IDEA sync#49843
Closed
erichaagdev wants to merge 1 commit intospring-projects:mainfrom
Closed
Skip running checks during IntelliJ IDEA sync#49843erichaagdev wants to merge 1 commit intospring-projects:mainfrom
erichaagdev wants to merge 1 commit intospring-projects:mainfrom
Conversation
Introduce conditional logic for making the `jar` task depend on `check` in `buildSrc`. This ensures that verification tasks do not run when the `idea.sync.active` system property is present. This prevents IntelliJ IDEA syncs from failing due to formatting issues or failing tests. A successful sync ensures developers retain full IDE functionality (like code completion and navigation) needed to easily resolve those very issues. Checks will still run as part of regular build tasks and cause the build to fail if there are issues. Signed-off-by: Eric Haag <ehaag@gradle.com>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks, @erichaagdev, but we don't want to introduce IDE-specific logic into the build. What works well for us is importing a fresh checkout into the IDE and then making changes. |
wilkinsona
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce conditional logic for making the
jartask depend oncheckinbuildSrc. This ensures that verification tasks do not run when theidea.sync.activesystem property is present.This prevents IntelliJ IDEA syncs from failing due to formatting issues or failing tests. A successful sync ensures developers retain full IDE functionality (like code completion and navigation) needed to easily resolve those very issues.
Checks will still run as part of regular build tasks and cause the build to fail if there are issues.