GH-4941: Add batchSize option to RedisItemReader for optimizing N+1 problem using Redis MGET #4942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a
batchSize
parameter toRedisItemReader
and its builder to solve the classic N+1 issue faced during batch reads from Redis.Currently,
RedisItemReader
executes individual GET commands per Redis key resulting in a significant number of network round-trips and performance bottlenecks.By enabling batch reading with Redis
MGET
whenbatchSize
> 1, this enhancement drastically reduces network calls and improves throughput while maintaining full backward compatibility whenbatchSize
is not set (default = 1).Key Changes
batchSize
property with default value1
inRedisItemReader
andRedisItemReaderBuilder
.batchSize
> 1, the reader fetches multiple keys in batch using RedismultiGet()
and internally buffers results.batchSize = 1
, ensuring no breaking changes.Benefits
Technical Considerations
Related Issue
Fixes #4941
"Terminated by KILL-9 SQUAD 💀"