Feat: add gpt 5 models and verbosity param #4086
Open
+85
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandros Pappas <[email protected]>
Signed-off-by: Alexandros Pappas <[email protected]>
|
@sobychacko @markpollack updating the latest changes from 1a3ed95 Gpt-5 models: https://platform.openai.com/docs/models |
amresh-das-promptpath
approved these changes
Aug 8, 2025
Signed-off-by: Alexandros Pappas <[email protected]>
apappascs
changed the title
amresh-das-promptpath
approved these changes
Aug 8, 2025
sunyuhan1998
approved these changes
Aug 8, 2025
sobychacko
reviewed
Aug 14, 2025
| * <p> | ||
| * Note: GPT-5 models require temperature=1.0 (default value). Custom temperature | ||
| * values are not supported and will cause errors. |
There was a problem hiding this comment.
Is this not the case anymore? In that case, we need to update the docs changed in this commit: https://github.com/spring-projects/spring-ai/pull/4068/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gpt-5 models and update their tests