Issue 3924 Fix MethodToolCallback enum argument handling #3933
+113
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MethodToolCallback not handling invalid enum arguments gracefully by converting
IllegalArgumentException to ToolExecutionException.
Closes #3924
Changes Made
buildMethodArguments()
inMethodToolCallback.call()
IllegalArgumentException
toToolExecutionException
withproper context
Technical Details
IllegalArgumentException
was thrown during enum conversion inJsonParser.toTypedObject()
but not caught byMethodToolCallback
MethodToolCallback.java
ToolExecutionExceptionProcessor
pipelineTest Results
ToolExecutionException
)MethodToolCallbackProviderTests
andDefaultToolCallingManagerTests
Files Modified
spring-ai-model/src/main/java/org/springframework/ai/tool/method/MethodToolCallback.java
spring-ai-model/src/test/java/org/springframework/ai/tool/method/MethodToolCallbackTests.java
(new file)
This change allows LLMs that provide invalid enum values to receive graceful error responses
instead of unhandled exceptions.
Signed-off-by: Mattia Pasetto [email protected]
Please make sure to double check and let me know if anything is wrong, this is my first contribution.