Fixes #51: Add support for @WebFilter to migrate-annotated-servlets r… - #1069
Open
m0hitchaudhary wants to merge 1 commit into
Open
Fixes #51: Add support for @WebFilter to migrate-annotated-servlets r…#1069m0hitchaudhary wants to merge 1 commit into
m0hitchaudhary wants to merge 1 commit into
Conversation
…migrate-annotated-servlets recipe Signed-off-by: m0hitchaudhary <11mohitchaudhary@gmail.com>
m0hitchaudhary
force-pushed
the
issue-51-webfilter
branch
from
August 27, 2026 08:10
f404da7 to
1a3432a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Pull Request Audit Report (Issue #51: "Add support for classes annotated with @webfilter")
1. Functional Completeness Verification
.\mvnw.cmd test -pl components/sbm-recipes-jee-to-boot,applications/spring-shell -DfailIfNoSpecifiedTests=falsesbm-recipes-jee-to-boot:SUCCESS(All unit tests passed includingMigrateAnnotatedServletRecipeTest)spring-shell:SUCCESS(26 tests run, 0 failures, 0 errors, 3 skipped docker-dependent tests)shouldMigrateWebFilterinMigrateAnnotatedServletsIntegrationTest.@WebFiltercorrectly resolvesmigrate-annotated-servletsas an applicable recipe.@ServletComponentScanalongside@SpringBootApplication.2. Code Quality & Standards Audit
TheFilter.javafollows the identical naming convention and package structure asTheServlet.java.shouldMigrateWebFilterfollows standard JUnit 5 method naming conventions used across the project.migrate-annotated-servlets.yamlupdated description to explicitly mention both servlets and filters.org.springframework.sbm.java.migration.conditions.HasImportStartingWith(value: javax.servlet.annotation).3. Git Hygiene Check
[NEW]TheFilter.java[MODIFY]migrate-annotated-servlets.yaml[MODIFY]MigrateAnnotatedServletsIntegrationTest.java