Skip to content

Revise update-learn-page action to not do condition if the token provided or not #102

Description

@artembilan

If we are aiming to make our release solution reusable for both OSS and commercial versions, then we should not do condition if token provided or not. It really has to be provided transparently in both environment.

Instead I suggest to provide a boolean flag to call project website API or Git commits directly.
Or even better: always call API and fallback to Git if there is no such an API.
I guess there is no for commercial, but that is what we can calculate by the repository we are in.

The token is always required and we always call project API for OSS, just because there is additional functionality behind the scene which would be by passed if we can Git directly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions