Allow encryptors other than authlogic_sha512 #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any higher makes tests intolerably slow when using bcrypt.
- Creates an encryptor preference. - Only includes Devise::Models::Encryptable if bcrypt is not used.
Author
|
Travis is failing because |
Contributor
|
@tristanm Pease rebase against current master, thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
:encryptorconfig option which allows developers to set encryptors other than justauthlogic_512. Any encryptor from Devise Encryptable should be able to be used, including custom encryptors, although I have only testedauthlogic_512andbcrypt.The default has been left as
authlogic_512to remain compatible with existing apps. However, all specs pass when the default is changed tobcrypt.Specs only check for the inclusion (or not) of
Devise::Models::Encryptableand the value ofDevise::Models::Encryptable#encryptor. I figure any other functional tests to do with the encryptors belong with the encryptors themselves in Devise. That said, let me know if there's anything else which needs to be tested.