Adds tini to images #63
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfrey-splunk
requested review from
guohuang,
clarafeb1,
pham-man,
dtwersky and
kdurril-splunk
guohuang
previously approved these changes
Jan 11, 2024
kdurril-splunk
previously approved these changes
Jan 11, 2024
|
Hi All, Time taken to update the service is ~2-3 minutes and service was in a healthy/replicated 1/1 state. |
dtwersky
reviewed
Sep 26, 2024
| {% endif %} | ||
| {{ splunk_home }}/bin/splunk start --nodaemon --accept-license --answer-yes --no-prompt | ||
|
|
||
| set -e |
There was a problem hiding this comment.
Can you explain why you added set -e?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tini to images as an init for proper signal forwarding/handling so that Splunk is stopped gracefully during service restarts. The tini version can be set via the tini_version ansible variable and defaults to a value of
v0.19.0