chore(release): merge develop to main #398
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Run `appinspect api` job for `release/` branches in `build-test-release` pipeline Ticket: https://splunk.atlassian.net/browse/ADDON-77779 Tested in the following cases where appinspect api job is: - Running for PR with “release/“ base: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/13626390125 - Running for manual trigger on “release/“ branch: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/13626413937 - Not running for chore/ branch: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/13626445165 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description [ [ADDON-78394](https://splunk.atlassian.net/browse/ADDON-78394) ] Added conditions skip tests, build, app-inspect and publish if the changes in PR are only related to documentation. Tests: https://docs.google.com/document/d/1IFxbIwzDM0lBkO3ciNxFrPlOPPE9YQhcaVStQg7lYEM/edit?usp=sharing ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description Added a new job validate-docs-change. This job will attempt to serve the documentation and fail if there are any errors. If errors occur, they will be printed in the check logs step. Another stage, enforce-docs-changes, reviews the result of validate-docs-change and uses run metadata to determine whether the job should fail the pipeline. When the PR targets the main branch, enforce-docs-changes will enforce failure on broken documentation and block merge. For other branches, it serves as an indicator of documentation issues without blocking the merge. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description This PR bumps the k8s-manifests-branch version from v3.3.2 to v3.4.1 related PR: splunk/ta-automation-k8s-manifests#120 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done - https://github.com/splunk/splunk-add-on-for-unix-and-linux/actions/runs/14701563721 --------- Co-authored-by: Dmytro Kvashnin <[email protected]>
### Description I think it makes more sense to make a fix release each time we update appinspect version. We'd prevent ourselves from rolling out the template each time there is a feat release of appinspect. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done No tests are needed
### Description update appinspect-cli-action to 2.10 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### The file `.github/workflows/reusable-build-test-release.yml` had merge conflicts when merging develop into main. This PR resolves those conflicts and syncs the changes accordingly. --------- Co-authored-by: mkolasinski-splunk <[email protected]> Co-authored-by: Dmytro Kvashnin <[email protected]> Co-authored-by: Dmytro Kvashnin <[email protected]> Co-authored-by: mgrandys-splunk <[email protected]> Co-authored-by: dvarasani-crest <[email protected]> Co-authored-by: kdoroszko-splunk <[email protected]>
### Description Run `appinspect api` job for `release/` branches in `build-test-release` pipeline Ticket: https://splunk.atlassian.net/browse/ADDON-77779 Tested in the following cases where appinspect api job is: - Running for PR with “release/“ base: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/13626390125 - Running for manual trigger on “release/“ branch: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/13626413937 - Not running for chore/ branch: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/13626445165 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description [ [ADDON-78394](https://splunk.atlassian.net/browse/ADDON-78394) ] Added conditions skip tests, build, app-inspect and publish if the changes in PR are only related to documentation. Tests: https://docs.google.com/document/d/1IFxbIwzDM0lBkO3ciNxFrPlOPPE9YQhcaVStQg7lYEM/edit?usp=sharing ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description Added a new job validate-docs-change. This job will attempt to serve the documentation and fail if there are any errors. If errors occur, they will be printed in the check logs step. Another stage, enforce-docs-changes, reviews the result of validate-docs-change and uses run metadata to determine whether the job should fail the pipeline. When the PR targets the main branch, enforce-docs-changes will enforce failure on broken documentation and block merge. For other branches, it serves as an indicator of documentation issues without blocking the merge. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
This PR bumps the k8s-manifests-branch version from v3.3.2 to v3.4.1 related PR: splunk/ta-automation-k8s-manifests#120 - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed - https://github.com/splunk/splunk-add-on-for-unix-and-linux/actions/runs/14701563721 --------- Co-authored-by: Dmytro Kvashnin <[email protected]>
### Description I think it makes more sense to make a fix release each time we update appinspect version. We'd prevent ourselves from rolling out the template each time there is a feat release of appinspect. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done No tests are needed
### Description update appinspect-cli-action to 2.10 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### The file `.github/workflows/reusable-build-test-release.yml` had merge conflicts when merging develop into main. This PR resolves those conflicts and syncs the changes accordingly. --------- Co-authored-by: mkolasinski-splunk <[email protected]> Co-authored-by: Dmytro Kvashnin <[email protected]> Co-authored-by: Dmytro Kvashnin <[email protected]> Co-authored-by: mgrandys-splunk <[email protected]> Co-authored-by: dvarasani-crest <[email protected]> Co-authored-by: kdoroszko-splunk <[email protected]>
### Description (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here) --------- Co-authored-by: mkolasinski-splunk <[email protected]> Co-authored-by: Dmytro Kvashnin <[email protected]> Co-authored-by: Dmytro Kvashnin <[email protected]> Co-authored-by: mgrandys-splunk <[email protected]> Co-authored-by: dvarasani-crest <[email protected]> Co-authored-by: kdoroszko-splunk <[email protected]>
siddharth-khatsuriya
changed the title
…" (#404) This reverts commit e30a821. ### Description This PR reverts the previous implementation of documentation validation and enforcement, and reintroduces those capabilities using a **reusable GitHub Actions workflow** along with a **template `validate-deploy-docs.yml` workflow file** in the template repository. ## Changes with PR reference - Removes the hardcoded docs validation logic. - Changes related to document validation and deployment is made in this PR: splunk/addonfactory-repository-template#743 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description Update develop to be inline with main branch. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description This PR removes the deprecated version (ubuntu 14.04) and add support of Ubuntu 20.04 and redhat 9.5 for scripted inputs. ### Checklist - [x] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [x] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done Test run: https://github.com/splunk/splunk-add-on-for-unix-and-linux/actions/runs/15417614522
Comment on lines
+432
to
+433
| find tests -type d -maxdepth 1 -mindepth 1 | sed 's|^tests/||g' | while read -r TESTSET; do echo "$TESTSET=${{ needs.check-docs-changes.outputs.docs-only == 'false' && 'true' || 'false' }}" >> "$GITHUB_OUTPUT"; echo "$TESTSET::${{ needs.check-docs-changes.outputs.docs-only == 'false' && 'true' || 'false' }}"; done | ||
| find package/default/data -type d -name "spl2" -maxdepth 1 -mindepth 1 | sed 's|^package/default/data/||g' | while read -r TESTSET; do echo "$TESTSET=${{ needs.check-docs-changes.outputs.docs-only == 'false' && 'true' || 'false' }}" >> "$GITHUB_OUTPUT"; echo "$TESTSET::${{ needs.check-docs-changes.outputs.docs-only == 'false' && 'true' || 'false' }}"; done |
There was a problem hiding this comment.
Not sure if we really need this change. AFAIK, the main goal for this job was to determine which test types are implemented in the TA repo. There are other factors that determines whether to execute those tests or not. For ex., result of the build stage (we are skipping the build stage for the doc-only so it would eventually skip executing those tests.)
There was a problem hiding this comment.
yes, made the change in PR: #415
| @@ -39,13 +39,13 @@ on: | |||
| required: false | |||
| description: "branch for k8s manifests to run the tests on" | |||
| type: string | |||
| default: "v3.3.3" | |||
| default: "v3.4.1" | |||
There was a problem hiding this comment.
We can update this to have the latest version i.e. v3.4.2
### Description Resolving develop -> main conflict ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here) --------- Co-authored-by: harshilgajera-crest <[email protected]> Co-authored-by: kdoroszko-splunk <[email protected]> Co-authored-by: mkolasinski-splunk <[email protected]> Co-authored-by: Dmytro Kvashnin <[email protected]> Co-authored-by: Dmytro Kvashnin <[email protected]> Co-authored-by: mgrandys-splunk <[email protected]> Co-authored-by: dvarasani-crest <[email protected]>
…release into main-dev-conflict
### Description (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes in the PR:
Checklist
README.mdhas been updated or is not requiredTesting done
FDR: https://github.com/splunk/splunk-add-on-for-crowdstrike-fdr/actions/runs/15320727045