Skip to content

feat(ui): add new datepicker component #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

sschimper-splunk
Copy link

@sschimper-splunk sschimper-splunk commented May 22, 2025

Issue number: 1758

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Added datepicker component to UI (using '@splunk/react-ui/Date') for modular inputs to facilitate the specification of date information.

Changes

  • added datepicker component to UI (using '@splunk/react-ui/Date')
  • added unit tests and storyboard file for this component
  • added section about this component to documentation

User experience

You can add the following to your globalConfig.json:

{
    "type": "date",
    "field": "example_date",
    "label": "Example Date",
    "help": "This is an example date field for the input one entity",
    "required": true
},

This generates a Datepicker component as shown below:

datepicker_component

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Caution

At the moment tests/smoke/test_ucc_build.py::test_ucc_generate_with_everything is failing after I introduced my changes.

Demo/meeting:
I can make myself available for a time that suits you.

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

Signed-off-by: Sebastian Schimper <[email protected]>
Signed-off-by: Sebastian Schimper <[email protected]>
Signed-off-by: Sebastian Schimper <[email protected]>
Signed-off-by: Sebastian Schimper <[email protected]>
Copy link

github-actions bot commented May 22, 2025

CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sschimper-splunk
Copy link
Author

I have read the Code of Conduct and I hereby accept the Terms
I have read the CLA Document and I hereby sign the CLA

@sschimper-splunk
Copy link
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant