Close #245. Make 1st token line height consistent #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds support for Espresso tests.
mgod
force-pushed
the
mw/android-tests
branch
from
3532942 to
e256e2b
Compare
|
Thank you for the great solution. It works perfectly for me. I have only one minor suggestion. A little adjustment is still needed to show a line with one token, so it's maybe a good idea to put a warning about it. |
mgod
force-pushed
the
mw/android-tests
branch
from
70b0291 to
deee728
Compare
|
I'm probably going to roll together a a few breaking changes and include this and some other improvements in a 3.0 release with notes on an upgrade path. Was the fix in your case to adjust the view height? I didn't have any trouble like this, so I'm not sure what fix to recommend. |
mgod
force-pushed
the
mw/android-tests
branch
from
deee728 to
03d33e7
Compare
|
I've tested it with Android Studio 3.0 and Support Library 26.1.0 and found no issue with your fix. It looked like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds support for Espresso tests.
@alexcustos I think this solves the line spacing a little more cleanly than #315. I was able to start with your changes and find a simpler solution that has the added benefit of aligning baselines if the token view support that. Can you check and let me know if this resolved the alignment issues you were seeing?