Resolved 6464-Windows-Services-Start-binPath-Args-issue #6465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdefaulter
requested review from
MarcosDY,
amartinezfayo,
evan2645,
rturner3 and
sorindumitru
as code owners
Member
amartinezfayo
left a comment
amartinezfayo
left a comment
There was a problem hiding this comment.
Thank you @xdefaulter for this contribution!
Could you please fix DCO and the lint issue so we can have this merged?
Thanks again!
|
@xdefaulter any idea when you will be able to resolve the merge issues? Don't want to be a prick and push it onto you but currently i can only use the sc start command which doesnt work with recovery so we are very interested in this fix. @amartinezfayo could this be hotfixed to 1.14.1 whenever it is merged? |
Signed-off-by: xdefaulter <[email protected]>
xdefaulter
force-pushed
the
bugfix/6464-Windows-Services-Start-binPath-Args-issue
branch
from
73674d4 to
a2ced48
Compare
Member
|
This has been merged and will be included in the 1.14.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Instead of using non-persistent Start Parameters in windows services as we do using code below.
We can use just create service command that will create the service with all the arguments. The arguments are persistent and the service can start automatically.
sc.exe create spire-server binpath= "c:\spire\bin\spire-server.exe run -config c:\spire\conf\server\server.conf"Description of change
In service_windows enterypoint, I have used os.Args that will accept Arguments form binPath. The code has condition to check if os.Args are valid if not then it will check Start Parameters Args if they are also invalid then it will throw error same as before.
Which issue this PR fixes
fixes #6464