Skip to content

With nanobind, nb_method is like instancemethod, a specific __name__ for methods #13836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

With nanobind, nb_method is like instancemethod, a specific __name__ for methods #13836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sphinx/util/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,8 @@ def isattributedescriptor(obj: Any) -> bool:
if isinstance(unwrapped, _DESCRIPTOR_LIKE):
# attribute must not be a method descriptor
return False
# attribute must not be an instancemethod (C-API)
return type(unwrapped).__name__ != 'instancemethod'
# attribute must not be an instancemethod (C-API) nor nb_method (specific for nanobind)
return type(unwrapped).__name__ not in {'instancemethod', 'nb_method'}
return False


Expand Down
Loading