Correct emitting, when rdmStarted is set to true #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phord
reviewed
Jan 12, 2018
| } | ||
| this.rdmStarted = true; | ||
| this.emit('rdmStarted') | ||
| this.emit('rdmStarted'); |
There was a problem hiding this comment.
Since this is a bug fix for the earlier commit, you should squash these into one commit before sending a pull-request. It keeps the project cleaner.
Author
There was a problem hiding this comment.
Finally got time to do it...
By the way do you have any clue why the CI is failing (seems unrelated to my change)
Linting wasn't enabled when rdm is manually started and rc_exec "discovers" it has already been started Update rtags.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting wasn't enabled when rdm is manually started and rc_exec "discovers" it has already been started