feat(test-specs): Allow automatic transaction gas-limit#9
Open
marioevz wants to merge 2 commits into
Open
Conversation
spencer-tb
approved these changes
May 29, 2026
4 tasks
Open
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
While reviewing ethereum#2901 I noticed that the bulk of its test changes were simply bumping the gas_limit of transactions in tests that don't actually care about the exact gas limit — they only care that the transaction executes in full without running out of gas.
This PR makes the transaction gas_limit optional. When a test omits it, the filling tool calculates it automatically:
The second commit applies this to existing tests, removing explicit gas_limit assignments from transactions across ~18 test files where the precise limit was irrelevant to what the test exercises.
Tests that should rely on the implicit gas limit are those that only need the transaction to execute fully and not run out of gas. Tests that intentionally probe gas-limit behavior continue to set it explicitly.
Open Issues
Execute command
The execute command depends on the gas limit to calculate the balance needed by the sender account. Some potential solutions:
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture