Skip to content

feat: Default CLI Authentication to RDA Flow#2157

Draft
KCarretto wants to merge 1 commit intomainfrom
auth-rda-default-9050903838038517202
Draft

feat: Default CLI Authentication to RDA Flow#2157
KCarretto wants to merge 1 commit intomainfrom
auth-rda-default-9050903838038517202

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

This submission changes the default CLI authentication mechanism from a local browser-based OAuth flow to a Remote Device Authentication (RDA) flow.

Users typically run Tavern CLI tools on remote systems (like SSH sessions) where local browser redirection is impossible. The previous default browser flow would often fail in these environments and then fallback to RDA. Making RDA the explicit default behavior removes this unnecessary failure path and improves the user experience.

The original browser flow is preserved and can be enabled by setting TAVERN_USE_BROWSER_OAUTH=1. Docs and tests have been updated appropriately.


PR created automatically by Jules for task 9050903838038517202 started by @KCarretto

Updates the `Authenticate` function in `tavern/cli/auth` to default to the Remote Device Authentication (RDA) flow. The previous default, which started a local HTTP server and opened a browser window for OAuth, is now hidden behind the `TAVERN_USE_BROWSER_OAUTH=1` environment variable. The CLI user guide in `docs/` has been updated to reflect this behavior change. Testing setup was also updated to continue utilizing the browser flow internally.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2896 2896 0 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1917 2896 2896 0 0 0 0 32.3s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2896 0 0 5m 46s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 12s 5m 46s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 12s 5m 46s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 12s 5m 46s
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant