Skip to content

Refactor debug logs behind verbose-logging feature flag#2154

Draft
hulto wants to merge 1 commit intomainfrom
jules-verbose-logging-15742468773140543664
Draft

Refactor debug logs behind verbose-logging feature flag#2154
hulto wants to merge 1 commit intomainfrom
jules-verbose-logging-15742468773140543664

Conversation

@hulto
Copy link
Copy Markdown
Collaborator

@hulto hulto commented Mar 29, 2026

Added verbose-logging feature to opt-in debug logging on release builds for implants

PR created automatically by Jules for task 15742468773140543664 started by @hulto

@google-labs-jules @hulto
Refactor debug logs behind verbose-logging feature flag
779b37d 
Adds `verbose-logging` feature to all Cargo crates in implants to
conditionally enable `log::` and `println!` debug statements. This
allows logs to be toggled gracefully in release builds by compiling
with `--features verbose-logging`. Replaces former hardcoded usages
of `#[cfg(debug_assertions)]` that disabled these prints.

Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

google-labs-jules bot commented Mar 29, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2893 2893 0 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1907 ✅ 2893 2893 0 0 0 0 40.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2893 0 0 6.1s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 6.1s 6.1s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
TestDockerExecutor_Build_SimpleEcho 1 4.5s 4.5s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hulto