Refactor imix config variables out of pb crate#2028
Draft
Conversation
Moved `config.rs` from `implants/lib/pb/src/` to `implants/imix/src/config/mod.rs` to break the dependency cycle where pb contained logic tied specifically to the imix agent. Refactored build scripts to process config logic inside the imix build.rs and leave pb build.rs handling only IMIX_SERVER_PUBKEY configuration needed by its `xchacha` library. Updated references in `transport` library to avoid depending on the config file from imix and to instead receive `pb::c2::Transport` definitions directly, and updated imix agent to extract and provide these representations properly. Cleaned up test configurations around the modified transport APIs. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Moved `config.rs` from `implants/lib/pb/src/` to `implants/imix/src/config/mod.rs` to break the dependency cycle where pb contained logic tied specifically to the imix agent. Refactored build scripts to process config logic inside the imix build.rs and leave pb build.rs handling only IMIX_SERVER_PUBKEY configuration needed by its `xchacha` library. Updated references in `transport` library to avoid depending on the config file from imix and to instead receive `pb::c2::Transport` definitions directly, and updated imix agent to extract and provide these representations properly. Cleaned up test configurations around the modified transport APIs. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Ran `cargo fmt` to resolve the formatting errors that caused the CI pipeline to fail during the rustfmt check in `implants`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
- Fixed `create_dns_test_config` test helper in `implants/lib/transport/src/dns.rs` to construct and return a `pb::c2::Transport` instead of relying on the old `Config` structure. - Removed unused imports and cleaned up warnings across multiple crates (`transport`, `eldritch-libreport`, `imix`, and `eldritch-wasm`). - Adjusted dead code and unused variables allowances where strictly necessary for specific OS compilation targets. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the imix agent and pb library to better separate their dependencies.
pblibrary and into theimixagent proper.transportcrate directly accept parsedpb::c2::Transportdefinitions rather than relying on the top-level imix Configuration type.PR created automatically by Jules for task 12433701274117575788 started by @KCarretto